Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updated remote config to include domain restrictions #26875

Merged
merged 21 commits into from
Dec 15, 2024
Merged

feat: Updated remote config to include domain restrictions #26875

merged 21 commits into from
Dec 15, 2024

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Dec 12, 2024 •
edited
Loading

Problem

We need a way to do some level of dynamic config checking

Changes

  • There is only one cached config entry now - the others are built in memory from that as they dont need other api calls
  • Checks the domain like before and sets the appropriate vary headers
  • Add tests to ensure the api works as expected
  • Validate the CDN caches based on vary header

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite marked this pull request as ready for review December 12, 2024 17:27
@benjackwhite benjackwhite requested a review from a team December 12, 2024 17:39
pauldambra
pauldambra approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little thinking out loud but 👍

@benjackwhite benjackwhite merged commit 0d830d6 into master Dec 15, 2024
89 checks passed
@benjackwhite benjackwhite deleted the feat/remote-config-authed-domains branch December 15, 2024 13:21
@sentry-io Sentry.io
Copy link

sentry-io bot commented Dec 15, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: can only join an iterable /array/{token}/config.js View Issue
  • ‼️ OperationalError: consuming input failed: query_wait_timeout posthog.tasks.remote_config.update_team_remote_... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverb123 oliverb123 oliverb123 approved these changes

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjackwhite @pauldambra @oliverb123